Week 11 Overall - Week 3 CST 338 Code Review

 

Savannah Kestral Code Review

Variable names – The variable names make a lot of sense. They correspond to their functions and contribute to the clarity of the code.

Logic – The logic is very efficient; there are even some things in her code that I didn’t think of.

Imports/warnings – There are no unused imports or warnings in her code.

Formatting – The code is perfectly formatted to the google style guide.

Unit Test - All of the unit tests passed.

This code is very well done; I do not really have any feedback. A lot of the code is self-explanatory and if it is not, the variables used help to explain it.

Isaiah Suarez Code Review

Variable names – The variable names make a lot of sense. They correspond to their functions and contribute to the clarity of the code.

Logic – The logic is very efficient

Imports/warnings – There are no unused imports or warnings in her code.

Formatting – The code is perfectly formatted to the google style guide.

Unit Test - All of the unit tests passed.

This code is very well done.

Xavier Mendoza Code Review

Variable names – The variable names make a lot of sense. They correspond to their functions and contribute to the clarity of the code.

Logic – The logic is very efficient

Imports/warnings – There are no unused imports or warnings in her code.

Formatting – The code is perfectly formatted to the google style guide.

Unit Test - All of the unit tests passed.

This code is very well done

 

Feedback about my code

Who said what? All of my teammates agree that my code was functional and for the most part okay. There was a method that I could have done differently to improve functionality, but overall I did an ok job.

Identify any trends you noticed when evaluating the code of others

A lot of code for this assignment was similar, but I believe that’s because this was a very straight forward assignment. Everybody had descriptive variables and thought most of the Javadoc comments were already generated, they were very descriptive. It does not seem like anybody had problems as everybody code passed the hangman test.

Answers to the following

1. What improvements would you make to your code/what was suggested? 
1. I would improve upon my method to pick a word. After reviewing other peoples code I see there is a way to do it much more effectively.
2. Which unit tests were the hardest to pass?
1. All of the tests were pretty easy to pass but if I had to pick one, I would go with the checkPlay test was hardest. That one required actual code and not just a simple one-line statement.
3. How do the existing tests function and could they be improved?
1. Do the existing unit tests cover the full range of the sub classes?
1. For the most part, input validation should also be incorporated.
2. How would you change the unit tests?
1. I would add an input validation test. I broke the game accidentally by
4. What did you struggle with?
1. I did not struggle with anything necessarily, I blanked a lot on the first method.
5. What did one of your teammates struggle with?
1. Mots of my teammates struggled with JavaDoc comments
6. Was any part of the code a struggle for YOU?
1. I struggled with the getWord part of the code as I was blanking completely on a way to do that.
7. Was any part of writing the code easy for YOU?
1. Most of the single line codes were easy for me and I love using my for each methods instead of for loops.
8. What was your biggest HW1 victory?
1. My biggest victory was that I actually was able to pass all of the unit tests without help. I remembered enough Java to make the methods I needed to from scratch.